ARROW-12063: [C++] Add null placement option to sort functions - #11212
ARROW-12063: [C++] Add null placement option to sort functions#11212pitrou wants to merge 1 commit into
Conversation
|
|
|
@ursabot please benchmark |
|
Benchmark runs are scheduled for baseline = 3317f83 and contender = d30564a. Results will be available as each benchmark for each run completes. |
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, thanks for pushing through all this.
|
LGTM, thank you! I'm curious why use a |
|
Even if we don't plan on extending the enum, personally I find something like |
|
Got it, makes sense, thanks. |
| for String arrays). | ||
|
|
||
| * \(4) The input must be an array. The default order is ascending. | ||
| * \(3) The input must be an array. The default order is ascending. |
There was a problem hiding this comment.
Consider adding here: "By default, nulls and NaNs come after any non-null values."
There was a problem hiding this comment.
It's already above in the section summary.
Closes apache#11212 from pitrou/ARROW-12063-sort-null-placement Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: David Li <li.davidm96@gmail.com>
4 participants
No description provided.